Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile 3839 #3780

Merged
merged 7 commits into from
Sep 12, 2023
Merged

Mobile 3839 #3780

merged 7 commits into from
Sep 12, 2023

Conversation

dpalou
Copy link
Contributor

@dpalou dpalou commented Sep 5, 2023

No description provided.

@NoelDeMartin NoelDeMartin self-requested a review September 6, 2023 06:47
NoelDeMartin
NoelDeMartin suggested changes Sep 6, 2023
View reviewed changes
cordova-plugin-moodleapp/src/ts/plugins/SecureStorage.ts Outdated Show resolved Hide resolved
cordova-plugin-moodleapp/src/ts/plugins/SecureStorage.ts Outdated Show resolved Hide resolved
cordova-plugin-moodleapp/src/ios/SecureStorage.m Outdated Show resolved Hide resolved
src/core/features/native/services/native.ts Outdated Show resolved Hide resolved
src/core/services/sites.ts Outdated Show resolved Hide resolved
cordova-plugin-moodleapp/src/ts/plugins/SecureStorage.ts Show resolved Hide resolved
@dpalou
Copy link
Contributor Author

dpalou commented Sep 7, 2023

Summary of the changes done so it's easier to review:

  • I implemented rollback for iOS (it's in the iOS commit). I had to abstract some code in new functions so I recommend reviewing the whole file again.
  • If you try to store undefined or null values they will be ignored (it's controlled in the TS code). At first I thought about throwing an error, but the privateToken is optional (some sites might not have it) so I decided not store it in that case. If you try to retrieve it then it won't be found so the returned object will not contain the property (it will be undefined).
  • In sites provider now the code is the same for all platforms.
  • Added a new commit to copy the plugin JS code to iOS platform and plugins folder.
  • Added a new commit to support SecureStorage in browser.

@NoelDeMartin NoelDeMartin merged commit e647e53 into moodlehq:main Sep 12, 2023
2 checks passed
@dpalou dpalou deleted the MOBILE-3839 branch November 17, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoelDeMartin NoelDeMartin NoelDeMartin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpalou @NoelDeMartin