Merge pull request #3723 from crazyserver/MOBILE-4362

Mobile 4362

.travis.yml

@@ -61,8 +61,6 @@ jobs:
       apt:
         packages:
         - libsecret-1-dev
-        - php5-cli
-        - php5-common
   - name: "Build iOS"
     language: node_js
     if: env(BUILD_IOS) = 1 AND (env(DEPLOY) = 1 OR (env(DEPLOY) = 2 AND tag IS NOT blank))

scripts/build.sh

@@ -1,13 +1,13 @@
 #!/bin/bash
 source "scripts/functions.sh"
 
-if [ -z $GIT_TOKEN ]; then
+if [ -z "$GIT_TOKEN" ]; then
     print_error "Env vars not correctly defined"
     exit 1
 fi
 
 print_title "Run scripts"
-git clone --depth 1 --single-branch --branch ionic5 https://$GIT_TOKEN@github.com/moodlemobile/apps-scripts.git ../scripts
+git clone --depth 1 --single-branch --branch ionic5 https://"$GIT_TOKEN"@github.com/moodlemobile/apps-scripts.git ../scripts
 cp ../scripts/*.sh scripts/
 
 if [ ! -f scripts/platform.sh ]; then

scripts/create_langindex.sh

@@ -9,7 +9,7 @@
 DIR="${BASH_SOURCE%/*}"
 if [[ ! -d "$DIR" ]]; then DIR="$PWD"; fi
 
-cd $DIR
+cd "$DIR"
 
 source "functions.sh"
 source "lang_functions.sh"
@@ -27,7 +27,7 @@ if [ ! -f 'langindex.json' ]; then
 fi
 
 findbetter=$1
-parse_file $findbetter
+parse_file "$findbetter"
 
 echo