Stop requiring the file phpdoc block for 1-artifact files #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stronk7
force-pushed
the
stop_requiring_filedoc_for_1_artifact
branch
from
29986e7
to
67af57c
Compare
Now we detect all the classes, interfaces and traits in a file and, if there is only one, then we stop requiring the file phpdoc block. This was agreed @ https://tracker.moodle.org/browse/MDLSITE-2804 and moodlehq#66 was created to implement it. Note this doesn't address the whole agreement, but just the detail about stop requiring the file phpdoc block, because it is specially annoying and recurring in new files (that use to be 1-artifact ones).
stronk7
force-pushed
the
stop_requiring_filedoc_for_1_artifact
branch
from
67af57c
to
30d4a80
Compare
sarjona
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we detect all the classes, interfaces and traits in a file
and, if there is only one, then we stop requiring the file
phpdoc block.
This was agreed @ https://tracker.moodle.org/browse/MDLSITE-2804
and #66
was created to implement it.
Note this doesn't address the whole agreement, but just the
detail about stop requiring the file phpdoc block, because it
is specially annoying and recurring in new files (that use to
be 1-artifact ones).