Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove noinlinephpdocs check #144

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Remove noinlinephpdocs check #144

wants to merge 2 commits into from

Commits on Mar 27, 2024

  1. Remove all checks for define() (moodlehq#141) 

    These checks never worked. The `get_defines()` method built a list of
definitions, added them to a `$defines` array, but return
`$this->defines` instead.

Furthermore there would be pandamonium if we actually fixed this because
we use constants in scripts all over Moodle with the same value, for
example:

```
define('CLI_SCRIPT', true);
```
    @andrewnicols
    andrewnicols committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    48ff9d3 View commit details
    Browse the repository at this point in the history

  2. Remove noinlinephpdocs check (moodlehq#144) 

    Replaced with moodlehq/moodle-cs#137
    @andrewnicols
    andrewnicols committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    d1580cd View commit details
    Browse the repository at this point in the history