Use Squizlabs Commenting sniffs for Method PHPDoc #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addss support for the standard Commenting sniffs relating to methods only. Some of the specific sniffs have been disabled, or their severity/type changed to suit our rules. Fixes moodlehq#30
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
=========================================
Coverage 96.24% 96.24%
Complexity 492 492
=========================================
Files 21 21
Lines 1384 1384
=========================================
Hits 1332 1332
Misses 52 52 ☔ View full report in Codecov by Sentry. |
|
Maybe we can discard this now that we have #30 to make it in an ordered and planned way? |
|
Agreed. I've also found that most of those sniffs actually are not suited. They do what we want, and then some other things too (grr) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addss support for the standard Commenting sniffs relating to methods only.
Some of the specific sniffs have been disabled, or their severity/type changed to suit our rules.
Fixes #30