Switch to latest Selenium + Chrome + Firefox versions #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are now passing with all of our tests. Fixes moodlehq#71
|
Hi, note I'm holding this on purpose till we release next Mon. Will happily review this then. Locally I've been running all test in the 4.1 release matrix using sele 4.6.0 and they have worked great, so far. |
|
Linking this with https://tracker.moodle.org/browse/MDL-77945 , because there is some information about actual runs there (it seems that Firefox results are far from good). Ciao :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #71, we can switch to the latest versions for these browsers since Firefox 4.6.0 (current).
This change also includes a commit to allow us to specify a different version via env variables and will allow us to run the beta (or dev) versions of these browsers. That can be done by setting the
SELVERSIONenv var to the relevant version of Selenium.