Some operations can fail if the date/time is not the expected one #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically, when using english, it works ok (en_US, en_AU.UTF-8, ...) but can fail with some collations like es_ES.UTf-8 when making some calculations because the expected formats are different from what the collation provides. So, we are going to use LC_ALL=C in all the "date" commands used by the scripts in order to provide a consistent behaviour no matter which collation is being used by default. We could also have set LC_TIME, LANG... but as far as LC_ALL is the one with max precedence, we just set that one, and only for the execution of the "date" commands. And "C", because that is the default, basic collation that all the systems support much like the POSIX one, only ASCII and enough for our interests).
sarjona
approved these changes
May 30, 2024
|
Tata! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, when using english, it works ok (en_US, en_AU.UTF-8, ...) but can fail with some collations like es_ES.UTf-8 when making some calculations because the expected formats are different from what the collation provides.
So, we are going to use LC_ALL=C in all the "date" commands used by the scripts in order to provide a consistent behaviour no matter which collation is being used by default.
We could also have set LC_TIME, LANG... but as far as LC_ALL is the one with max precedence, we just set that one, and only for the execution of the "date" commands. And "C", because that is the default, basic collation that all the systems support much like the POSIX one, only ASCII and enough for our interests).