Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPS: commented out obviously unneeded dependencies for Linux-only build, ~5GiB in total #111

Open
wants to merge 1 commit into
base: skiasharp
Choose a base branch
from

Conversation

Mis012
Copy link

@Mis012 Mis012 commented Sep 2, 2023

Description of Change

do not needlessly download ~5GiB of data that is not actually needed

API Changes

None.

Behavioral Changes

None.

PR Checklist

EDIT: it seems these dependencies are in fact needed for a general build.
the pull request now instead adds a new DEPS file in build/linux-self-hosted/DEPS.

if https://github.com/mono/SkiaSharp/wiki/Building-on-Linux is updated to add
cp build/linux-self-hosted/DEPS DEPS before python tools/git-sync-deps, this will
save downloading ~5GiB of unused dependencies

@Mis012
Copy link
Author

Mis012 commented Sep 2, 2023

@dotnet-policy-service agree

@Gillibald
Copy link

Why is the emsdk not needed when Skia is build for wasm?

@Mis012
Copy link
Author

Mis012 commented Sep 2, 2023

well, it would be needed in that case, but afaik you are never building it for wasm?
EDIT: hm, guess I missed that line in the list in the README
now these dependencies make more sense

@Mis012
Copy link
Author

Mis012 commented Sep 2, 2023

it seems the git-sync-deps script supports specifying which OS a particular dependency is needed for, so maybe that could be used to avoid 5GiB of dependencies for wasm when following https://github.com/mono/SkiaSharp/wiki/Building-on-Linux, but I don't see how exactly one would do that

use `cp build/linux-self-hosted/DEPS DEPS` to avoid downloading
~5GiB of dependencies which are not needed for a Linux build
@Mis012
Copy link
Author

Mis012 commented Sep 2, 2023

in light of the dependencies being in fact necessary for the general build, I have reduced the scope to only affect the builds done according to https://github.com/mono/SkiaSharp/wiki/Building-on-Linux, which would happen by virtue of a copy command being added to the guide

@Mis012 Mis012 changed the title DEPS: commented out obviously unneeded dependencies, ~5GiB in total DEPS: commented out obviously unneeded dependencies for Linux-only build, ~5GiB in total Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants