Do not stretch the background #2922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When resizing a view, the background will be stretched making the image distorted and not a great experience. This PR make sure to never scale the background brush and rather keep it top-left aligned.
mattleibow
commented
Jul 4, 2024
Comment on lines
+104
to
+105
| var newDpi = root?.RasterizationScale ?? 1.0; | ||
| if (newDpi != Dpi) |
There was a problem hiding this comment.
This check here prevents hundreds of invalidations. The XamlRootChanged event will fire when any of the properties of the XAML root changes. This does not seem to fire just when the current view gets a new XAML root as the name implies.
github-actions bot
pushed a commit
that referenced
this pull request
Jul 5, 2024
* Do not stretch the background When resizing a view, the background will be stretched making the image distorted and not a great experience. This PR make sure to never scale the background brush and rather keep it top-left aligned. * Update SKXamlCanvas.cs * Scale the brush instead of stretching it (cherry picked from commit 3ace63b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When a view is resized, the canvas is not yet resized and updated to match. Before this PR, the canvas would be stretched to fill the view. This PR make sure to not stretch the canvas but instead keep it fixed.
The reason for the scaling in the first place is that
WriteableBitmapdoes not have a DPI parameter. As a result, we have to create a larger bitmap than the view such that when it is scaled down to match the view size, the resolution matches that of the rest of the app. Previously, the larger canvas was just squashed to fit, but this was non-uniform. This PR always scales the canvas to the correct size preserving the aspect ratio.Bugs Fixed
API Changes
None.
Behavioral Changes
None.
Required skia PR
None.
PR Checklist