Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update harfbuzz to 7.3.0 #2582

Merged
merged 25 commits into from
Aug 29, 2023
Merged

Update harfbuzz to 7.3.0 #2582

merged 25 commits into from
Aug 29, 2023

Conversation

mattleibow
Copy link
Contributor

@mattleibow mattleibow commented Aug 24, 2023

Description of Change

A quite large update with a whole bunch of security, bug and performance fixes.

Bugs Fixed

API Changes

None.

Behavioral Changes

None.

Required skia PR

mono/skia#104

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Merged related skia PRs
  • Changes adhere to coding standard
  • Updated documentation

github-actions bot and others added 19 commits August 17, 2023 06:54
(cherry picked from commit 75835cc)

Co-authored-by: Matthew Leibowitz <[email protected]>
Truncation will chop off parts, and this will lose value. Flooring outwards ensure that the size touches the edge of the containing rect. This is useful that any partial overhang with integer sizes can be clipped when drawing.

(cherry picked from commit 8fd4dc5)

Co-authored-by: Matthew Leibowitz <[email protected]>
@mattleibow mattleibow added the backport/release/2.x Backport this PR to release/2.x label Aug 24, 2023
@mattleibow mattleibow merged commit ab230d4 into main Aug 29, 2023
1 of 2 checks passed
@mattleibow mattleibow deleted the dev/update-harfbuzz-v3 branch August 29, 2023 02:22
@github-actions
Copy link

The backport to release/2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/2.x release/2.x
# Navigate to the new working tree
cd .worktrees/backport-release/2.x
# Create a new branch
git switch --create backport/pr-2582-to-release/2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ab230d481240aad4ce6f33453c8289c9f851d9d5
# Push it to GitHub
git push --set-upstream origin backport/pr-2582-to-release/2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/2.x

Then, create a pull request where the base branch is release/2.x and the compare/head branch is backport/pr-2582-to-release/2.x.

mattleibow added a commit that referenced this pull request Aug 29, 2023
\
# Conflicts:
#	externals/skia
#	scripts/VERSIONS.txt
mattleibow added a commit that referenced this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/release/2.x Backport this PR to release/2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] HarfBuzz CVE-2023-25193 when referencing SkiaSharp.NativeAssets.Linux.NoDependencies
1 participant