Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the hot path of the path iterators #1677

Closed
wants to merge 2 commits into from
Closed

Conversation

mattleibow
Copy link
Contributor

@mattleibow mattleibow commented Mar 30, 2021

Description of Change

Expose the raw pointers for the Next method so consumers can opt into a much more performant run.

Benchmark code: https://gist.github.com/mattleibow/7f7f554d8717caa065970081b8ffd115

image

Bugs Fixed

  • Related to issue #

API Changes

SKPathVerb SKPath.Iterator.Next(SKPoint* points);
SKPathVerb SKPath.RawIterator.Next(SKPoint* points);

Behavioral Changes

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Updated documentation

Expose the raw pointers for the Next method so consumers can opt into a much more performant run.
@mattleibow mattleibow added this to the v2.88.1 milestone May 22, 2022
@mattleibow mattleibow modified the milestones: v2.88.1, v2.88.x Planning Sep 11, 2022
@mattleibow
Copy link
Contributor Author

Negligible improvement.

@mattleibow mattleibow closed this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant