Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vector stuff #149

Merged
merged 2 commits into from
Sep 13, 2024
Merged

vector stuff #149

merged 2 commits into from
Sep 13, 2024

Conversation

PeenScreeker
Copy link
Member

This pull request updates the vector functions in math.ts to be more flexible with respect to vectors in 2D/3D. 2D functions can be called on 3D vectors ignoring the z component. Base functions will handle either 2D or 3D vectors.

Checks

  • I have thoroughly tested all of the code I have modified/added/removed to ensure something else did not break
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits.
  • Fully tokenized all my strings (no hardcoded English strings!!) and supplied bulk JSON strings below

@PeenScreeker PeenScreeker merged commit 3028525 into feat/mom-0.10 Sep 13, 2024
1 check passed
@PeenScreeker PeenScreeker deleted the feat/vector branch September 13, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants