Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

region visualization and misc QoL #145

Merged
merged 4 commits into from
Aug 28, 2024
Merged

region visualization and misc QoL #145

merged 4 commits into from
Aug 28, 2024

Conversation

PeenScreeker
Copy link
Member

@PeenScreeker PeenScreeker commented Aug 28, 2024

This PR improves the following zoning UI features:

  • Ensure correct region menu is shown based on tab selection
  • Zoning edits only reset when "Cancel Edit" is clicked. Closing the zone menu no longer resets zone defs
  • Zones render changes as properties are modified
  • Newly created zones are initialized with default height
  • Picking a corner below the current region bottom updates the region bottom value
  • Point picking mode now shows visualization of region points before region is defined

Requires red changes to render zone visualization while picking points.

Checks

  • I have thoroughly tested all of the code I have modified/added/removed to ensure something else did not break
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits.
  • Fully tokenized all my strings (no hardcoded English strings!!) and supplied bulk JSON strings below

Copy link
Member

@tsa96 tsa96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, so excited to show this off.

@tsa96 tsa96 merged commit af806d4 into feat/mom-0.10 Aug 28, 2024
1 check passed
@tsa96 tsa96 deleted the feat/visualization branch August 28, 2024 13:20
@tsa96
Copy link
Member

tsa96 commented Aug 29, 2024

Oh sorry I probably merged this too soon, wanted to get this in so I could rebase my typescript porting stuff on top

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants