Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display end-of-run graph time strings on y-axis #115

Merged
merged 2 commits into from
Jan 20, 2024

Conversation

benjl
Copy link
Contributor

@benjl benjl commented Jan 19, 2024

Closes momentum-mod/game/issues/1995

Made the time axis of the end of run graph use formatting based on the extents of the graph, using just seconds, m:ss, or h:mm where appropriate, and increased spacing slightly so that longer labels like +mm:ss don't shrink down.
(Also, I used $.Localize() to check what stat is being compared and I'm not entirely sure if it's bad to do or not)

Checks

  • I have thoroughly tested all of the code I have modified/added/removed to ensure something else did not break
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits.
  • Fully tokenized all my strings (no hardcoded English strings!!) and supplied bulk JSON strings below

@benjl
Copy link
Contributor Author

benjl commented Jan 19, 2024

image
image
image
image
image

scripts/components/graphs/line-graph.js Outdated Show resolved Hide resolved
Copy link
Member

@tsa96 tsa96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for this :)

scripts/components/graphs/line-graph.js Outdated Show resolved Hide resolved
@benjl benjl force-pushed the graph-time-labels branch 2 times, most recently from 5818d08 to a910c72 Compare January 20, 2024 00:58
@tsa96 tsa96 merged commit b69d81d into momentum-mod:master Jan 20, 2024
1 check passed
@benjl benjl deleted the graph-time-labels branch January 22, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display times on end of run graph axis as time strings
2 participants