Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Panorama panel and event names #112

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

JJL772
Copy link
Member

@JJL772 JJL772 commented Jan 17, 2024

Update panel/event names for the Panorama naming refactor. Bulky PR, but no functional changes were made.

This will probably cause some disruptions with pending PRs, although rebasing should be straightforward.

Do not merge until the internal PR is merged.

Checks

  • I have thoroughly tested all of the code I have modified/added/removed to ensure something else did not break
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits.
  • Fully tokenized all my strings (no hardcoded English strings!!) and supplied bulk JSON strings below N/A

@JJL772
Copy link
Member Author

JJL772 commented Jan 18, 2024

Ok, this should be good to merge now. I have merged the internal PR, so this will need to go in before the next momentum update.

@PeenScreeker PeenScreeker merged commit 6d4b087 into momentum-mod:master Jan 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants