Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(catalogue): variable list should show +n when repeat info is set #4259

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

fix(catalogue): variable list should show +n when repeat info is set #4259

wants to merge 5 commits into from

Conversation

mswertz
Copy link
Member

@mswertz mswertz commented Sep 26, 2024 •
edited
Loading

closes #4259

What are the main changes you did:

  • changes to variables page

how to test:

  • browse to catalogue-demo -> TestNetwork -> Variables -> testRepeatVar_ and see that a +x is shown
  • go to harmonisation matrix, click testRepeatVar_ and see "Repeated for'

todo:

  • fix the +1 bubble
  • fix the popup to also show repeatvar info

@mswertz mswertz marked this pull request as draft September 26, 2024 07:20
@mswertz
Copy link
Member Author

mswertz commented Sep 28, 2024

@BrendaHijmans please share your opinion on this new indicator of repeats:
image

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connoratrug connoratrug connoratrug approved these changes

@BrendaHijmans BrendaHijmans Awaiting requested review from BrendaHijmans

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mswertz @connoratrug