-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat (tailwind): init radio and radio group components #4231
base: master
Are you sure you want to change the base?
Conversation
v-model="modelValue" | ||
:value="value" | ||
type="radio" | ||
class="w-5 h-5 ml-[6px] mr-2.5 mt-0.5 accent-yellow-500 hover:cursor-pointer" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
</ul> | ||
<h3>Input radio group examples</h3> | ||
<form class="mt-4 [&_fieldset]:mb-4"> | ||
<fieldset class="flex flex-col gap-1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add a case where the value is already set ( tests the initial value is correctly set)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General input functionality works, think we need to change to double synced arrays ( see comment for details )
Would suggest adding it the the FormField so we can test the form interaction
few small design tweaks needed to match design ( maybe have a look a the ontology filter classes )
Quality Gate passedIssues Measures |
What are the main changes you did:
how to test:
todo: