Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(upload): remove eager circular errors when superclass points to subclass #4088

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix(upload): remove eager circular errors when superclass points to subclass #4088

wants to merge 6 commits into from

Conversation

mswertz
Copy link
Member

@mswertz mswertz commented Jul 30, 2024 •
edited
Loading

closes #4086

What are the main changes you did:

  • remove circular check (it is actually too eager)

how to test:

todo:

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@mswertz mswertz marked this pull request as draft July 30, 2024 07:42
@mswertz mswertz changed the title fix: eager circular errors when superclass points to subclass fix(upload): remove eager circular errors when superclass points to subclass Jul 30, 2024
@mswertz mswertz marked this pull request as ready for review July 30, 2024 16:10
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 30, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrendaHijmans BrendaHijmans Awaiting requested review from BrendaHijmans

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@mswertz