Prevent accessing @driver unless set #319
Conversation
src/support/index.coffee
Outdated
| @driver.close() | ||
| @driver.quit() | ||
| else | ||
| $.defer() |
There was a problem hiding this comment.
shouldn't we return just a resolved promise here instead of a defered object that is in a non resolved state?
There was a problem hiding this comment.
Probably mate yeah. This was just any old crap that worked in five minutes. Just to raise the issue more than anything - was in a rush!
Cheers,Tom
On Mon, Apr 27, 2015 at 10:14 PM, Sam Saccone [email protected]
wrote:
@@ -105,7 +105,10 @@ module.exports = ->
argv['prevent-browser-reload']?terminateDriver = =>
- @driver.close()
- @driver.quit()
- if @driver?
@driver.close()@driver.quit()- else
$.defer()shouldn't we return just a resolved promise here instead of a defered object that is in a non resolved state?
Reply to this email directly or view it on GitHub:
https://github.com/mojotech/pioneer/pull/319/files#r29192054
There was a problem hiding this comment.
The other way is to check the existence of driver before calling terminate. Probably cleaner.
Cheers,Tom
On Mon, Apr 27, 2015 at 10:14 PM, Sam Saccone [email protected]
wrote:
@@ -105,7 +105,10 @@ module.exports = ->
argv['prevent-browser-reload']?terminateDriver = =>
- @driver.close()
- @driver.quit()
- if @driver?
@driver.close()@driver.quit()- else
$.defer()shouldn't we return just a resolved promise here instead of a defered object that is in a non resolved state?
Reply to this email directly or view it on GitHub:
https://github.com/mojotech/pioneer/pull/319/files#r29192054
There was a problem hiding this comment.
yeah I think this the idea behind this is a good PR. mind just updating a touch and we can get this merged in?
There was a problem hiding this comment.
Yeh man I'll sort it tomorrow. Hate depending on our own forks!
Cheers,Tom
On Mon, Apr 27, 2015 at 10:40 PM, Sam Saccone [email protected]
wrote:
@@ -105,7 +105,10 @@ module.exports = ->
argv['prevent-browser-reload']?terminateDriver = =>
- @driver.close()
- @driver.quit()
- if @driver?
@driver.close()@driver.quit()- else
$.defer()yeah I think this the idea behind this is a good PR. mind just updating a touch and we can get this merged in?
Reply to this email directly or view it on GitHub:
https://github.com/mojotech/pioneer/pull/319/files#r29194433
There was a problem hiding this comment.
👍 no prob thanks for the awesome work ps
When there are zero steps in a file (as can happen when excluding certain tags in a test run) it attempts to close the driver, having never created it in the first place.
For some reason, certain commands are not failing leaving the scenario running for ever, causing our test runs to hang. The old version of selenium does seemingly not have this problem.
Multiple tags should be supplied in multiple --tags arguments, which allows logical ORs and ANDs to be applied to tags. This creates --tags arguments according to the cucumber docs: https://github.com/cucumber/cucumber/wiki/Tags tags: ['@one', '~@two'] will run scenarios with tag @one, but not scenarios with tag @two.
tomhicks-bsf
force-pushed
the
master
branch
from
a29477f
to
5596e0b
Compare
0.3.2 was accidentally unpublished from npm can cannot be re added!
Probably gives no benefit We're moving to node6, and the fixed dependencies might be causing issues
This reverts commit 26eebc6. Sticking with node 0.12 for now, so put the shrinkwrap back
When there are zero steps in a file (as can happen when excluding
certain tags in a test run) it attempts to close the driver, having
never created it in the first place.