Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AdditionalSqrt #4452

Open
wants to merge 1 commit into
base: maint/4.1.x
Choose a base branch
from
Open

AdditionalSqrt #4452

wants to merge 1 commit into from

Conversation

Esther-Devakirubai
Copy link

Backport #4396

@Esther-Devakirubai Esther-Devakirubai added L: Complex* Issue addresses Complex, Modelica.ComplexBlocks or Modelica.ComplexMath L: Media Issue addresses Modelica.Media labels Aug 16, 2024
@Esther-Devakirubai Esther-Devakirubai mentioned this pull request Aug 16, 2024
Merged
@beutlich beutlich added this to the MSL4.1.0 milestone Aug 16, 2024
casella
casella requested changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@casella casella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Esther-Devakirubai #4396 affects four files, while this backport only affects two. I guess there are some additional commits missing

@Esther-Devakirubai
Copy link
Author

@Esther-Devakirubai #4396 affects four files, while this backport only affects two. I guess there are some additional commits missing

Will check.

@Esther-Devakirubai
Copy link
Author

@Esther-Devakirubai #4396 affects four files, while this backport only affects two. I guess there are some additional commits missing

Will check.

@casella I see only 2 files being affected by this.

1be54b5

Please correct me if I am wrong.

@maltelenz
Copy link
Contributor

@Esther-Devakirubai there are more commits in #4396 : https://github.com/modelica/ModelicaStandardLibrary/pull/4396/commits

but this PR only contains the contents of one of them.

@casella
Copy link
Contributor

casella commented Sep 17, 2024

@Esther-Devakirubai there are more commits in #4396 : https://github.com/modelica/ModelicaStandardLibrary/pull/4396/commits

but this PR only contains the contents of one of them.

Yes, the #4396 PR contains multple commits, but for some reason the cherry-picking only considered the first one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casella casella casella requested changes

@maltelenz maltelenz Awaiting requested review from maltelenz

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
L: Complex* Issue addresses Complex, Modelica.ComplexBlocks or Modelica.ComplexMath L: Media Issue addresses Modelica.Media
Projects
None yet
Milestone
MSL4.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Esther-Devakirubai @maltelenz @casella @beutlich @HansOlsson