Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the text displayed on the checks page #690

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .env.test
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ [email protected]
GITHUB_PASSWORD=whocaresthiswon'tbeused
GITHUB_CLIENT_ID=trash
GITHUB_CLIENT_SECRET=alsotrash
LMKW_TRELLO_DEVELOPER_PUBLIC_KEY=trash
2 changes: 2 additions & 0 deletions .tool-versions
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
postgres 10.18
ruby 3.1.0
4 changes: 1 addition & 3 deletions app/views/checks/_list.html.haml
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,9 @@
%span.check-value.target-value= check.target_value
%h3
= icon(*check.icon, class: "fa-lg")
= check.name
%p
- options = check.manual? ? {} : { target: :_blank, rel: :noreferrer }
= link_to(check.url, options) do
visit #{check.service}
= check.name
%span.fas.fa-external-link-alt
.card-actions
- params = { check: { refresh: true } }
Expand Down
7 changes: 7 additions & 0 deletions list.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
* fix automated tests
* automated tests verify whether code works
*
* fix linters
* fork repo
* push up branch
* make pull request
9 changes: 6 additions & 3 deletions spec/system/check_counts/new_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,10 @@
require "rails_helper"

RSpec.describe "check_counts/new", type: :system, js: true do
def user_creates_count
click_link("visit manual")
def user_creates_count(check)
# binding.pry
click_link(check.name)
# click_link("Manual Check 100")

fill_in(:Value, with: 10)

Expand All @@ -15,6 +17,7 @@ def user_creates_count
check = create(:manual_check)
sign_in(default_user)

expect { user_creates_count }.to activate_check(check.name).in(page)
expect { user_creates_count(check) }
.to activate_check(check.name).in(page)
end
end