Skip to content

Commit

Permalink
#672: Fix for the Chutzpah doesn't discover JS tests in which AmdPath…
Browse files Browse the repository at this point in the history
…s with Pascal case for the test modules are added

Issue:
We have one project which has amdPath added for each JS files ( including test files). When I tried running tests using chutzpah on the project. I found that some portion of amdPath generated by chutzpah for the test files is still coming in lower case.

While I can see that as part of commit “5145879: fix path casing” done on 12 Nov 2017, @mmanela fixed most of the casing issue in the test file path generation. but we are still hitting into the test file path casing issue.

Fix
=====
Passing  lowerCase flag = false to NormalizeFilePath in the method FindScriptFiles()
  • Loading branch information
sulabh-msft committed Dec 11, 2017
1 parent 5145879 commit e567c9c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Chutzpah/FileProbe.cs
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ public IEnumerable<PathInfo> FindScriptFiles(ChutzpahTestSettingsFile chutzpahTe

// The path we assume default to the chuzpah.json directory if the Path property is not set
var testPath = string.IsNullOrEmpty(pathSettings.Path) ? pathSettings.SettingsFileDirectory : pathSettings.Path;
testPath = UrlBuilder.NormalizeFilePath(testPath);
testPath = UrlBuilder.NormalizeFilePath(testPath, false);
testPath = testPath != null ? Path.Combine(pathSettings.SettingsFileDirectory, testPath) : null;

// If a file path is given just return that file
Expand Down Expand Up @@ -283,4 +283,4 @@ private string GetReferenceFileContentAndSetHash(ReferencedFile file, ChutzpahTe
return text;
}
}
}
}

0 comments on commit e567c9c

Please sign in to comment.