Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use llm-foundry for ICL metrics #287

Merged
merged 8 commits into from
Jul 23, 2024
Merged

Conversation

ysharma1126
Copy link
Contributor

composer deprecated support for ICL metrics, should now be using llm-foundry instead

@achalddave
Copy link
Collaborator

thanks for the PR! Any reason for removing the InContextLearningQAAccuracy and InContextLearningCodeEvalAccuracy in this PR?

@ysharma1126
Copy link
Contributor Author

ysharma1126 commented Jun 30, 2024

those metrics aren't in foundry, could add to the foundry wrapper, or fix composer to a version prior to deprecation

@achalddave
Copy link
Collaborator

ah interesting, thanks. it looks like InContextLearningQAAccuracy was renamed (mosaicml/llm-foundry#936) to InContextLearningGenerationExactMatchAccuracy. The code eval was deprecated mosaicml/llm-foundry@b301869.

Could you update this to replace InContextLearningQAAccuracy with InContextLearningGenerationExactMatchAccuracy, and remove the commented line for code evals?

Thanks!

…ExactMatchAccuracy, and removed the commented line for code evals
@ysharma1126
Copy link
Contributor Author

updated!

@sedrick-keh-tri sedrick-keh-tri merged commit 9bb92ef into mlfoundations:main Jul 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants