Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete modelgauge merge #465

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Complete modelgauge merge #465

merged 4 commits into from
Sep 20, 2024

Conversation

bkorycki
Copy link
Contributor

PR #455 merged in modelgauge from commit 44d1a0da36b10176f3d1aeb15e569d54cbb93f45. This PR merges in the last dangling changes from modelgauge PR 560.

@bkorycki bkorycki requested a review from a team as a code owner September 20, 2024 02:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@bkorycki bkorycki changed the title Merge encapsulate annotators Complete modelgauge merge Sep 20, 2024
wpietri
wpietri approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@wpietri wpietri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for doing all this!

rogthefrog
rogthefrog approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@rogthefrog rogthefrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

rogthefrog
rogthefrog approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@rogthefrog rogthefrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed after the catch-up commits, looks good! Thanks for doing that, and sorry about the inadvertent changes introduced by my linter (shouldn't happen again).

@bkorycki bkorycki merged commit 2b93191 into main Sep 20, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wpietri wpietri wpietri approved these changes

@rogthefrog rogthefrog rogthefrog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkorycki @wpietri @rogthefrog