Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mlcube edit command #598

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Mlcube edit command #598

wants to merge 23 commits into from

Conversation

VukW
Copy link
Contributor

@VukW VukW commented Jun 17, 2024

Addresses #344 . Creates a medperf mlcube edit command that updates existing mlcube:

  • uid [required]. uid of desired mlcube
  • name [optional]
  • mlcube-file [optional]
  • parameters-file [optional]
  • image-file [optional]
  • additional-file [optional]

TODO:

  • tests

Requires #586 to be merged

hasan7n and others added 23 commits April 27, 2024 07:21
Co-authored-by: Viacheslav Kukushkin <[email protected]>
Co-authored-by: Viacheslav Kukushkin <[email protected]>
# Conflicts:
#	cli/cli_tests.sh
if no other params are given, pytest.fixture.params is treated as list of <param> and one param is passed to test function at once. In our case it would be just str keys.
New storage allows to use both get/upload/edit in the same test (say, upload and then get & check)
@VukW VukW requested a review from a team as a code owner June 17, 2024 15:41
@VukW VukW had a problem deploying to testing-external-code June 17, 2024 15:41 — with GitHub Actions Failure
Copy link
Contributor

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants