Send exec status independent of report permissions #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristizabal95
temporarily deployed
to
testing-external-code
GitHub Actions
Inactive
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
aristizabal95
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
aristizabal95
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
aristizabal95
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
aristizabal95
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
aristizabal95
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
aristizabal95
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
aristizabal95
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
aristizabal95
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
aristizabal95
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
aristizabal95
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
aristizabal95
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
aristizabal95
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
aristizabal95
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
VukW
reviewed
Jun 24, 2024
VukW
reviewed
Jun 24, 2024
VukW
reviewed
Jun 24, 2024
|
|
||
| self.ui.print("> Cube execution complete") | ||
| if self.allow_sending_reports: | ||
| if not self.dataset.for_test: |
There was a problem hiding this comment.
It seems you don't need this check anymore. report_sender expected to work well both with real data and test
There was a problem hiding this comment.
Can you check plz one more time if everything between report_sender.start/stop/* and _send_data() works well for test datasets (as I believe you are more experienced in this piece of code). I believe it works well, just to explicitly ensure
There was a problem hiding this comment.
Good point, I'm removing this check. Also everything looks fine with the report_sender methods, so I think we're good there!
VukW
reviewed
Jun 24, 2024
VukW
previously approved these changes
Jun 24, 2024
Co-authored-by: Viacheslav Kukushkin <[email protected]>
aristizabal95
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
Co-authored-by: Viacheslav Kukushkin <[email protected]>
aristizabal95
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
Co-authored-by: Viacheslav Kukushkin <[email protected]>
aristizabal95
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
aristizabal95
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
status: waiting for experiment leads to decide on wether this is OK