Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Torch profiling #905

Conversation

pranayasinghcsmpl
Copy link
Contributor

Fixes #639

Proposed Changes

  • Added Profiling option in run command
  • Added Torch Profiler that prints cpu_time_total for both CPU & GPU

Checklist

  • CONTRIBUTING guide has been followed.
  • PR is based on the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
  • Code has been blacked for style consistency and linting.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

@pranayasinghcsmpl pranayasinghcsmpl requested a review from a team as a code owner July 25, 2024 09:16
Copy link
Contributor

github-actions bot commented Jul 25, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@sarthakpati sarthakpati marked this pull request as draft July 25, 2024 13:32
@sarthakpati
Copy link
Collaborator

Please update the tests (or add a new one) to ensure that the new code is covered, and we are going to wait till #845 is merged to merge this in.

@pranayasinghcsmpl
Copy link
Contributor Author

Alright, no problem.

@sarthakpati sarthakpati deleted the branch mlcommons:new-apis_v0.1.0-dev July 31, 2024 14:21
@sarthakpati
Copy link
Collaborator

sarthakpati commented Jul 31, 2024

Please change the base of this PR to master and re-open.

@pranayasinghcsmpl
Copy link
Contributor Author

Sure, I am working on a way to avoid the test case errors.

@sarthakpati
Copy link
Collaborator

@pranayasinghcsmpl - wanted to touch base about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants