feat(KNNClassifier): This adds typescript support for KNNClassifier #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds Typescript support and build configuration. Tested on KNNClassifier. For now its very loosely typed, but this change can serve as the initial building block. adding typescript support #253
|
Hi @Sab94 thank you so much for taking the time for this contribution! Based on the discussion in #253 I think we'd prefer to test the idea of typescript out with a new model rather than revising existing classes. If that goes well, we can consider porting things like this KNNClassifier. Would you prefer we leave this open as a reminder for future consideration (it would have to be updated due to recent changes / conflicts?) or would you be ok if we close and continue the discussion in #253? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Typescript support and build configuration. Tested on KNNClassifier. For now its very
loosely typed, but this change can serve as the initial building block.
adding typescript support #253