Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devops] Allow TypeScript files alongside Javascript #1388

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

lindapaiste
Copy link
Contributor

Extends #1379 -- review/merge that first
Related issue: #253

  • Creates the correct configurations for a mixed TS/JS project (in webpack.common.babel.js, .eslintrc.js, and tsconfig.json).
  • Installs a bunch of dev dependencies.
  • Converts one file callCallback.js to TS so that we have some TypeScript to check.
  • Removes the //ts-check in BodyPix as there are a lot of errors in that file. Those errors are a problem when building with TS.

Both develop and build ran successfully!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops SEMVER/minor a version tag for a minor release change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants