fix preload bugs (#305)

ml5js · Mar 15, 2019 · 7a51432 · 7a51432
1 parent fc311e3
commit 7a51432
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/utils/p5PreloadHelper.js b/src/utils/p5PreloadHelper.js
@@ -20,8 +20,20 @@ export default function registerPreload(obj) {
     const fn = obj[key];
 
     preloadFn[key] = function preloads(...args) {
-      return fn.apply(obj, [...args, function doingPreloads() {
+      let originCallback = null;
+      let argLen = args.length;
+      if (typeof args[argLen - 1] === 'function') {
+        // find callback function attached
+        originCallback = args[argLen - 1];
+        argLen -= 1;
+      }
+      return fn.apply(obj, [...args.slice(0, argLen), function doingPreloads() {
         const targetPreloadFn = '_decrementPreload';
+        try {
+          if (originCallback) originCallback();
+        } catch (err) {
+          console.error(err);
+        }
         if (window[targetPreloadFn]) return window[targetPreloadFn]();
         return null;
       }]);

diff --git a/webpack.test.babel.js b/webpack.test.babel.js
@@ -5,6 +5,7 @@
 
 import { existsSync, mkdirSync, writeFileSync, lstatSync } from 'fs';
 import { join } from 'path';
+import assert from 'assert';
 import merge from 'webpack-merge';
 import common from './webpack.common.babel';