Release triplets #100
Merged
Release triplets #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around hitting the path limits on windows
daschuer
force-pushed
the
release_triplets
branch
from
48996be
to
18eeb5b
Compare
| @@ -131,7 +132,7 @@ jobs: | |||
| working-directory: ${{ matrix.vcpkg_path }} | |||
|
|
|||
| - name: Build packages | |||
| run: ./vcpkg install --vcpkg-root=${{ matrix.vcpkg_path }} --clean-after-build --recurse ${{ env.VCPKG_PACKAGES }} | |||
| run: ./vcpkg install --vcpkg-root=${{ matrix.vcpkg_path }} --x-buildtrees-root=${{ matrix.vcpkg_buildtrees-root }} --clean-after-build --recurse ${{ env.VCPKG_PACKAGES }} | |||
There was a problem hiding this comment.
Why is this only needed for 2.5? Should it be backported to 2.4?
There was a problem hiding this comment.
Because Qt6 uses onger paths.
|
LGTM! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream has added community triplets for release only.
We can now remove the windows triplet form the overlay.
I have adjusted the name of the other triplets accordingly.
This is also a prerequisite for caching single packages in the upcoming manifest-mode PR #80