-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Umar/2168 separately track publish date and build date #2284
base: master
Are you sure you want to change the base?
Umar/2168 separately track publish date and build date #2284
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we want the opposite changes. Specifically, we want build
date updates to be triggered both by user-initiated publish actions and by the mass build pipeline (i.e., the last time that the course site was built) and publish
date updates to be triggered only by user-initiated publish actions. So the publish
date should stay the same when the mass build pipeline runs.
244968b
to
c77229a
Compare
This is correct, but I'd like to clarify a bit more. Am I right that: build: current release branch of theme and content are checked out and hugo builds the HTML. publish: main branch of content repo is merged into release branch and then build process is followed. |
Revert "fixed variable names" This reverts commit d8fdacf0e0c9ad1afbbe9b292dcae5107cc3ed84. fixed variable names removed publish status key updates in mas builds
b073e25
to
1317392
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Just a few minor suggestions regarding phrasing in the documentation.
@@ -409,6 +410,11 @@ You should now have a pipeline in Concourse called `e2e-test-pipeline`. Run this | |||
- Deploy them to Minio | |||
- Run Playwright tests against the output | |||
|
|||
### Publish And Build Dates | |||
|
|||
- Publishing site from Studio for live and draft versions, updates the website properties `(live_build_date, publish_date)` and `(draft_build_date, draft_publish_date)` respectively. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Publishing site from Studio for live and draft versions, updates the website properties `(live_build_date, publish_date)` and `(draft_build_date, draft_publish_date)` respectively. | |
- Publishing the site from Studio for live and draft versions updates the website properties `(live_build_date, publish_date)` and `(draft_build_date, draft_publish_date)`, respectively. |
### Publish And Build Dates | ||
|
||
- Publishing site from Studio for live and draft versions, updates the website properties `(live_build_date, publish_date)` and `(draft_build_date, draft_publish_date)` respectively. | ||
- Mass build for live and draft versions only updates the website properties `live_build_date` and `draft_build_date` respectively. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Mass build for live and draft versions only updates the website properties `live_build_date` and `draft_build_date` respectively. | |
- Running the mass build for live and draft versions only updates the website properties `live_build_date` and `draft_build_date`, respectively. |
What are the relevant tickets?
Fixes #2168
Description (What does it do?)
This change separately tracks the build and publish dates for live/draft versions. The publish dates are updated on
mass_build
which indicates no content change. Build dates and publish dates are both updated onpublish from studio
.How can this be tested?
umar/2168-separately-track-publish_date-and-build_date
branchocw-studio
docker-compose exec web ./manage.py showmigrations websites
0057_website_draft_build_date_website_live_build_date
docker-compose exec web ./manage.py migrate websites
ocw-studio
locally atlocalhost:8043/sites
or use an existing one.ocw-studio
and Wait for the publish operation to complete.localhost:8043/admin
and search for the site inWebsites
.publish date
will be updated for the site.docker-compose exec web ./manage.py mass_publish <live or draft> --filter <site-name>
Build date
andPublish date
have been updated.