-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated header #1622
base: main
Are you sure you want to change the base?
updated header #1622
Conversation
3e15b9c
to
4aba19c
Compare
…de of the trigger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be some extra padding around the header. Figma is showing 72p height but locally its coming out to 76px.
@shanbady We actually had a discussion about this in Slack, but there seems to be an issue with Figma here. If you look at the box model for the header element in a browser, it is correctly including the bottom 4px border: In Figma, the height is shown as "72px" because it's not including the 4px bottom border, even though it is shown in their box model: I've confirmed with @mbilalmughal that the height is correct as-is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also have a mit-logo-learn.jpg which is used in subscription emails - https://learn.mit.edu/static/images/mit-logo-learn.jpg - are we leaving this as the old one for now or should this get swapped out as well (also worth noting it is intentionally a jpg for email template support)
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/5305
Description (What does it do?)
This PR implements the new site header as shown in the issue above and the screenshots below.
Screenshots (if appropriate):
How can this be tested?
mit-learn
on this branch