Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning message to DEDP dashboard #5399

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Conversation

annagav
Copy link
Contributor

@annagav annagav commented Sep 24, 2024

What are the relevant tickets?

Fix https://github.com/mitodl/hq/issues/5519

Description (What does it do?)

Adds a warning message.

The program records link was shown only to programs that had exams (aka DEDP) and can be turned off through a flag FEATURE_PROGRAM_RECORD_LINK.

I also removed the FA calculation card that appeared before the course rows.

Screenshots (if appropriate):

Screenshot 2024-09-25 at 4 11 55 PM

@annagav annagav changed the title Ag/link program record Add warning message to DEDP dashboard Sep 24, 2024
Copy link

@rachellougee rachellougee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't setup MM to test locally but the code looks good to me.

@pdpinch
Copy link
Member

pdpinch commented Sep 27, 2024

Since we're working on this, let's apply this warning message to all programs. We just need to change the link for edx.org programs to go to edx.org instead of MITx Online.

Copy link

@rachellougee rachellougee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can test this locally now. The message looks good on DEDP program id=2. You may want to update the message for all program per Peter's comment.

One issue I noticed that there is a trailing space in the modified file FinancialAidCard_test.js https://github.com/mitodl/micromasters/pull/5399/files#diff-ad8eb2397d0a3bb35daab569f07d3d3dca98ea6b2ed090ad5eb79eb9446f2a88. Not sure why the test didn't warn that.

@pdpinch
Copy link
Member

pdpinch commented Sep 30, 2024

@pdpinch what should we link users to in mitxonline and in edx.org?

for edx.org, we can link them to the program dashboard, https://courses.edx.org/dashboard/programs/

for mitxonline, we can link them to the dashboard, https://mitxonline.mit.edu/dashboard

for mitxonline users without a socialauth, we should tell them to create an account with the same email address. We can display the email address we have on record for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants