Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle promise rejections #4983

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Handle promise rejections #4983

merged 1 commit into from
Jul 26, 2021

Conversation

umarmughal824
Copy link
Contributor

@umarmughal824 umarmughal824 commented Jul 13, 2021

Pre-Flight checklist

  • Testing
    • Code is tested
    • Changes have been manually tested

What are the relevant tickets?

fixes #4934

What's this PR do?

Handle promise rejections on the /dashboard page

How should this be manually tested?

Just visit the dashboard page and see everything is functional

@odlbot odlbot temporarily deployed to micromasters-ci-pr-4983 July 13, 2021 13:14 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2021

Codecov Report

Merging #4983 (ada776c) into master (6709ecb) will not change coverage.
The diff coverage is 100.00%.

❗ Current head ada776c differs from pull request most recent head d899e95. Consider uploading reports for the commit d899e95 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4983   +/-   ##
=======================================
  Coverage   94.14%   94.14%           
=======================================
  Files         496      496           
  Lines       22834    22834           
  Branches      916      916           
=======================================
  Hits        21496    21496           
  Misses       1242     1242           
  Partials       96       96           
Impacted Files Coverage Δ
static/js/containers/DashboardPage.js 86.96% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6709ecb...d899e95. Read the comment docs.

@umarmughal824 umarmughal824 temporarily deployed to micromasters-ci-pr-4983 July 15, 2021 08:28 Inactive
Copy link
Contributor

@annagav annagav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@umarmughal824 umarmughal824 merged commit 94554ac into master Jul 26, 2021
@umarmughal824 umarmughal824 deleted the umar/fix-4910 branch July 26, 2021 09:17
@odlbot odlbot mentioned this pull request Jul 26, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnhandledRejection: Non-Error promise rejection captured with value: undefined
4 participants