Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initialiser location #2574

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mansona
Copy link
Contributor

@mansona mansona commented Feb 17, 2024

Having the main initialiser in the app folder means that a consuming app can't actually override the initialiser.

This means that you can't have an embroider safe implementation that works in Fastboot, because we can't have a fastboot-specific ember-cli-mirage initialiser that doesn't (eventually) import pretender. This means that even though pretender doesn't actually work in node there is no way to prevent it being imported in your app, until this PR is merged 👍

@@ -106,8 +106,8 @@ module.exports = {
});
},

treeForApp(appTree) {
let trees = [appTree];
treeForAddon(addonTree) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mansona could you please explain a bit this change?

I got the point about initializer location in app folder and that totally makes sense. But this change seems separate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants