Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create models/foo.js exporting a ShimModelClass #2551

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bartocc
Copy link
Contributor

@bartocc bartocc commented Oct 4, 2023

This PR is here to illustrate this issue of discoverEmberDataModels with ShimModelClass

Run pnpm --filter="basic-app" start && open http://localhost:4200 to see the error in the console

You can also

Open in StackBlitz

@@ -0,0 +1 @@
export default class Foo {}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per 3cd81ef#r129177371 agree with @cah-brian-gantzler that this is not supposed to work as it's not Ember Data model

@cah-brian-gantzler
Copy link
Collaborator

This #2556 is related and after looking into it, it appears a test is done too late. See the issue.

@gilest
Copy link
Contributor

gilest commented Feb 26, 2024

Try rebasing now that #2569 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants