Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback using @embroider/macros #2381

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from

Conversation

SergeAstapov
Copy link
Collaborator

@SergeAstapov SergeAstapov commented Apr 12, 2022

We can't bump @embroider/macros beyond 0.41.0 as it requires Node.js v12 and v2 of ember-cli-mirage depends on Node.js 10

using older version of @embroider/macros causes issues for users of this addon hence this PR replaces back usage of @embroider/macros with require.has() or require.entries.

Closes #2343.

We can't bump `@embroider/macros` beyond 0.41.0 as it requires Node.js v12
and v2 of ember-cli-mirage depends on Node.js 10

using older version of `@embroider/macros` causes issues for users of this addon
hence this PR replaces back usage of `@embroider/macros` with
`require.has()` or `require.entries`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant