Unify browserName
given through different sources
#390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The browser name can be specified through these places:
$browserName
driver constructor argument;$desiredCapabilities['browserName']
key of the desired capabilities (either given upon driver construction or later on).Both browser names have no relation to each other which can lead to inconsistent driver configuration, e.g.
$this->browserName
set to thechrome
, but in$this->desiredCapabilties['browserName']
set to thefirefox
.P.S.
Nobody was noticing any bugs, because the
\WebDriver\WebDriver::session
method (a dependency of this project) has a polyfill code, that does the same thing as this PR.The above-mentioned polyfill code is removed in 2.x releases of the WebDriver, which allowed us to spot this problem.