Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve "Selenium2Driver::applyTimeouts" error handling for Selenium 3 support #380

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Improve "Selenium2Driver::applyTimeouts" error handling for Selenium 3 support #380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Selenium2Driver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
use Behat\Mink\KeyModifier;
use Behat\Mink\Selector\Xpath\Escaper;
use WebDriver\Element;
use WebDriver\Exception\InvalidArgument;
use WebDriver\Exception\NoSuchElement;
use WebDriver\Exception\StaleElementReference;
use WebDriver\Exception\UnknownCommand;
Expand Down Expand Up @@ -370,6 +371,10 @@
$this->getWebDriverSession()->timeouts($type, $param);
}
} catch (UnknownError $e) {
// Selenium 2.x.
throw new DriverException('Error setting timeout: ' . $e->getMessage(), 0, $e);
} catch (InvalidArgument $e) {

Check warning on line 376 in src/Selenium2Driver.php

View check run for this annotation

Codecov / codecov/patch

src/Selenium2Driver.php#L376 

Added line #L376 was not covered by tests
// Selenium 3.x.
throw new DriverException('Error setting timeout: ' . $e->getMessage(), 0, $e);
}
}
Expand Down
Loading