Fixed the execution of self-executing functions not wrapped in braces

[stof]

No description provided.

[aik099]

No such problem for Sahi/Zombie?

[aik099]

The Sahi test suite is running terribly slow by the way (compared to Selenium2). Maybe we're setting some kind of script running speed and it's stuck in Sahi settings until all tests are done?

[stof]

@aik099 not yet checked.

[stof]

and regarding the Sahi speed, this is indeed terrible. However, I don't know sahi enough to know what it could be.
Please open an issue on the SahiDriver repo for this

[stof]

@aik099 Can you run the zombie suite to check it ? I cannot. Installing Zombie on Windows does not work

[aik099]

and regarding the Sahi speed, this is indeed terrible. However, I don't know sahi enough to know what it could be.
Please open an issue on the SahiDriver repo for this

Done: https://github.com/Behat/MinkSahiDriver/issues/35

[aik099]

@aik099 Can you run the zombie suite to check it ? I cannot. Installing Zombie on Windows does not work

I'm on Mac and have Linux virtual machine. So I can run Zombie in both places. Don't you have virtual machine on Windows to simulate close-to-server environment, @stof?

I've tried to run Zombie tests and it freezes on some test. The output is:

PHPUnit 3.7.28 by Sebastian Bergmann.

Configuration read from .../phpunit.xml

...........SSSSSSSS...S...............

[aik099]

I wonder if it would be possible to print test names before running them somehow. Then it's would be obvious which test freezes.

[stof]

run them using the --tap output

[aik099]

It's testExecuteScript with dataset #0 hanging.

[aik099]

And it's freezing because of a bug in that executeScript method of a driver.

Current code (with error):

public function executeScript($script)
{
    $script = json_encode($script);
    $this->server->evalJS("browser.evaluate({$script});");
}

Fixed code (you can send a PR):

public function executeScript($script)
{
    $script = json_encode($script);
    $this->server->evalJS("browser.evaluate({$script});stream.end();");
}

The stream.end() added.

---

After fixing that locally (in ZombieDriver code) all but 2 tests pass:

1) Tests\Behat\Mink\Driver\ZombieDriverTest::testExecuteScript with data set #2 ('function () {document.querySelector("h1").textContent = "Hello world";}()')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Hello world'
+'Extremely useless page'

...vendor/behat/mink/tests/Behat/Mink/Driver/JavascriptDriverTest.php:310

2) Tests\Behat\Mink\Driver\ZombieDriverTest::testExecuteScript with data set #3 ('function () {document.querySelector("h1").textContent = "Hello world";}();')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Hello world'
+'Extremely useless page'

...vendor/behat/mink/tests/Behat/Mink/Driver/JavascriptDriverTest.php:310

[stof]

OK, the fix is the same than for Selenium2DRiver then: it requires the wrapping braces

[stof]

and this made us discover that executeScript is broken in ZombieDriver since years

[stof]

Can you open the PR fixing MinkZombieDriver ? You are the one doing the debugging after all, so it would be logical that you get the attribution for the fixing commit

[aik099]

Can you open the PR fixing MinkZombieDriver ? You are the one doing the debugging after all, so it would be logical that you get the attribution for the fixing commit

I'll do that.

We should really introduce these nice badges, that Symfony community has for amount of contributions been done by a particular user, here at Behat company. :)

[aik099]

PR for Zombie created. You can merge it now.

[stof]

We should really introduce these nice badges, that Symfony community has for amount of contributions been done by a particular user, here at Behat company.

AFAIK, SensioLabsConnect can generate the contributing page for any project once you register it. I'm not sure they have an easy way to embed it on other websites though, but it could be considered for the new Behat website which should be in progress