Cleanup, use semicolon to not break csv

ministryofjustice · Jul 13, 2023 · 3aa2957 · 3aa2957
1 parent c40a80f
commit 3aa2957
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 8 deletions.
diff --git a/app/javascript/src/runner/index.js b/app/javascript/src/runner/index.js
@@ -37,19 +37,13 @@ function initializeCookieBanner() {
 
 function initializeMultifileUploadPage() {
   const addAnotherButton  = document.querySelector('[data-multiupload-element="add-another-file"]');
-  // const uploadFile  = document.querySelector('[data-multiupload-element="upload-another-file"]');
 
   if(!addAnotherButton) return;
-  // if(!uploadFile) return;
 
   addAnotherButton.addEventListener('click', function(e) {
     e.preventDefault();
     window.multiupload.showFileUpload();
   })
-
-  // uploadFile.addEventListener('click', function() {
-  //   window.multiupload.upload();
-  // })
 }
 
 /*

diff --git a/app/services/platform/submitter_payload.rb b/app/services/platform/submitter_payload.rb
@@ -224,7 +224,7 @@ def upload(answer)
     def multiupload(answer)
       return '' if answer.nil?
 
-      answer.values.first.map { |i| i['original_filename'] }.join('<br>').html_safe
+      answer.values.first.map { |i| i['original_filename'] }.join('; ')
     end
 
     def autocomplete(answer)

diff --git a/spec/services/platform/submitter_payload_spec.rb b/spec/services/platform/submitter_payload_spec.rb
@@ -186,7 +186,7 @@ def content_components_text
         heading: '',
         answers: [
           {
-            answer: 'basset-hound.jpg<br>basset-hound.jpg',
+            answer: 'basset-hound.jpg; basset-hound.jpg',
             field_id: 'dog-picture_upload_2',
             field_name: 'Upload your best dog photos'
           }