Develop #481
Develop #481
Conversation
|
Please set a versioning label of either |
ggodlewski
force-pushed
the
develop
branch
4 times, most recently
from
eca80f7
to
caa91fc
Compare
| VOLUME_DATA=/home//wikigdrive | ||
| VOLUME_PREVIEW=/home//wikigdrive-preview | ||
| DOMAIN=localhost | ||
| DOMAIN=http://localhost:3000 |
There was a problem hiding this comment.
do we no longer need RENDER_IMAGE , VOLUME_DATA and VOLUME_PREVIEW?
maybe we should consider adding here placeholders for variables related to JWT and zipkin URL?
There was a problem hiding this comment.
In https://github.com/mieweb/wikiGDrive/blob/develop/website/docs/developer-guide.md#running-locally-with-docker we specify those env variables in docker run command
I we use both .env file and -e RENDER_IMAGE... it's not clear which env would be used by wikigdrive.
|
|
||
| jobs: | ||
| test: | ||
| if: github.event.pull_request.head.ref != 'develop' && contains( github.event.pull_request.labels.*.name, 'deploy-pr') |
There was a problem hiding this comment.
Why do we want to limit it? Does building/testing take too much time?
There was a problem hiding this comment.
Wikigdrive starts watching each shared drive for changes. It seems that the more watchers we use the slower they work. Each additional instance is another set of connections to the API.
apps/ui/assets/main.css
Outdated
|
|
||
| .prism-editor__editor { | ||
| font-size: 16px; | ||
| font-family: monospace !important; |
There was a problem hiding this comment.
Does it work without !important? If not, maybe it would be better to use an id instead of a class as CSS selector?
No description provided.