Develop #422
Merged
Develop #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 10, 2024
horner
approved these changes
Feb 10, 2024
| - run: sudo apt-get update | ||
| - run: sudo apt-get install -y libkrb5-dev | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 18 | ||
| registry-url: https://npm.pkg.github.com/ |
There was a problem hiding this comment.
this fails. so lets try the official one. https://github.com/mieweb/wikiGDrive/actions/runs/7603328576
| - run: sudo apt-get update | ||
| - run: sudo apt-get install -y libkrb5-dev | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 18 | ||
| registry-url: https://npm.pkg.github.com/ | ||
| registry-url: 'https://registry.npmjs.org' |
|
|
||
| git reset --hard | ||
| git checkout master --force |
There was a problem hiding this comment.
this will make sure we get the remote even if the branch does not exist.
| @@ -61,7 +61,7 @@ export class MainService { | |||
| } | |||
|
|
|||
| async init() { | |||
| this.mainFileService = new FileContentService(this.params.workdir || process.cwd()); | |||
| this.mainFileService = new FileContentService(this.params.workdir || '/data'); | |||
There was a problem hiding this comment.
this is a big assumption about running in the container. What happens if not in the container?
| @@ -41,7 +41,7 @@ async function main() { | |||
| process.env.PWD = process.cwd(); | |||
|
|
|||
| const filesIds = args.slice(1); | |||
| const workdir = argv['workdir'] || process.env.WIKIGDRIVE_WORKDIR || '/data'; | |||
| const workdir = argv['workdir'] || process.env.VOLUME_DATA || '/data'; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.