Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - Multiple Compression/Encoding Methods #6

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

cseufert
Copy link

@cseufert cseufert commented Jul 13, 2021

Refactored CompressEncoder to support multiple methods in a single middleware, with backward compact

  • Single Middleware for compression, that out of the box configures itself based on what PHP extensions are available (zstd, or brotli)
  • Orderable based on compression preference if required
  • Individual compression methods can have their compression level adjusted where required.

To do:

  • Update Documentation
  • Setup testing with zstd and brotli extensions loaded
  • Write an upgrade guide going from version 2.x to 3.x
  • Fix/workaround PHP Stan warnings about brotli_compress
  • Add deprecation PHPDOC to GzipEncoder and Deflate Encoder classes
  • Add unit tests for multiple compressor logic

@cseufert cseufert mentioned this pull request Jul 13, 2021
@cseufert
Copy link
Author

@oscarotero Could you let me know if this has the possibility of being merged (open to suggestions on structural changes).

@oscarotero
Copy link
Member

Hi, @cseufert
Thanks, I really like your proposal :).

Let me know when you have finished with this changes and I'll merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants