Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version: Nvidia.CUDA version 12.6.1 #172790

Conversation

marklani
Copy link
Contributor

@marklani marklani commented Sep 11, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@marklani
Copy link
Contributor Author

Installation is fine on my computer. There should be no issue with the package as it is the same installer as in this merged PR #170631 . This PR is important to have better versioning of the package. (Currently version 12.6.1 is patched on top of version 12.6.0 as version 12.6)

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Sep 11, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Installation failed with exit code -1978335226
2024-09-11 02:45:51.814 [CLI ] ShellExecute installer failed: 2148270085

Automated error analysis suggests -1978335226 may mean Running ShellExecute failed

(Automated response - build 895.)

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Sep 11, 2024
@stephengillie stephengillie added Validation-Completed Validation passed and removed Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Shell-Execute labels Sep 11, 2024
@stephengillie stephengillie merged commit 7398479 into microsoft:master Sep 11, 2024
5 of 7 checks passed
@SpecterShell
Copy link
Contributor

@marklani It's not recommended to use the full version for this package, as WinGet relies on the version value of the ARP entries the installer wrote to the registry to check updates, which, however, only have two parts. Doing so may cause an update loop for users.

image

@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@aisgbnok
Copy link
Contributor

aisgbnok commented Sep 21, 2024

Installation is fine on my computer. There should be no issue with the package as it is the same installer as in this merged PR #170631. This PR is important to have better versioning of the package. (Currently version 12.6.1 is patched on top of version 12.6.0 as version 12.6)

Unfortunately this PR #172790 and #172785 cause an update loop as @SpecterShell predicted. See: #174522.

Better versioning of the package is hard to achieve because NVIDIA's installer only writes MAJOR.MINOR semver (12.6) to the Windows registry. @SpecterShell's approach of swapping the installer (#170631) is probably best given Winget's "limitations" in this instance.

There may be alternatives if you must have "better versioning of the package", such as using DisplayVersion, but that comes with it's own set of issues. (See Google.AndroidStudio: #174516 (comment), #150629 (comment))


This package's PackageVersion: 12.6.1 does not match DisplayVersion from Windows ARP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants