Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: Romanitho.Winget-AutoUpdate version 1.20.0 #152510

Conversation

G0rocks
Copy link
Contributor

@G0rocks G0rocks commented May 7, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@G0rocks
Copy link
Contributor Author

G0rocks commented May 7, 2024

Made with wingetcreate

@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Installation failed with exit code -1978335226
2024-05-07 04:56:25.634 [CLI ] ShellExecute installer failed: 4294967295

Automated error analysis suggests -1978335226 may mean Install successful but system restart may be required.

(Automated response - build 880.)

@G0rocks
Copy link
Contributor Author

G0rocks commented May 8, 2024

Yeah I tried checking the source (https://github.com/Romanitho/Winget-AutoUpdate/blob/main/Sources/WAU/Winget-AutoUpdate/Winget-Install.ps1) for this installation error code but I didn't find it. No clue what it's about.
Tagged the developer of WAU via issue: Romanitho/Winget-AutoUpdate#625
@Romanitho if you (or anybody else) know what's going on and how to fix it then that would be great, otherwise I'm closing this PR

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels May 8, 2024
@stermic2
Copy link

stermic2 commented May 9, 2024

@G0rocks I have to ask... The WinGet Auto-Update Configurator seems to be an installer, with extra steps, for WinGet Auto-Update.

I may be wrong, (there might not be an alternative) but installing an installer seems to be inferior to just installing with whatever extra parameters the configurator might be pushing.

Asking out of curiosity, I'm looking into WinGet Auto-Update for Enterprise use and need to learn. I'm concerned that an installer that downloads files after 'installing' also circumvents the security advantages of Winget.

You can tell me bluntly if I'm not making sense. I'm just beginning my research on the matter.

PackageIdentifier: Romanitho.Winget-AutoUpdate
PackageVersion: 1.20.0
InstallerType: zip
NestedInstallerType: exe
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
NestedInstallerType: exe
NestedInstallerType: portable

@stephengillie stephengillie added Needs-Author-Feedback This needs a response from the author. Changes-Requested Changes Requested and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels May 9, 2024
@AndrewDemski-ad-gmail-com

Automatic Validation ended with:

Installation failed with exit code -1978335226
2024-05-07 04:56:25.634 [CLI ] ShellExecute installer failed: 4294967295

Automated error analysis suggests -1978335226 may mean Install successful but system restart may be required.

Far from it, APPINSTALLER_CLI_ERROR_SHELLEXEC_INSTALL_FAILED was returned for a fully scripted product and winget does not support those yet.
https://github.com/microsoft/winget-cli/blob/5fe31fc8710514f0f3f08d18d8043c43352e3f73/schemas/JSON/settings/settings.schema.0.2.json#L126-L137

About WAU
There is a ton of PS1 files, 1 VBS file, 1 LNK file and good old ServiceUI.exe, the installation procedure requires running PS1 file with some additional/optional parameters.
Product could be installed either from scripted install action in deployment type in SCCM application or from intunewin file with little to no effort.
The installation logic is invoked only once and updates are pulled directly from github by dedicated scheduled task.

Moving/conversion of the update flow away from scripted solution backed by GitHub to winget pkgs repo was most likely not discussed with author of the WAU ( @Romanitho ).

@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity No activity has occurred on this work item for seven days. label May 17, 2024
@AndrewDemski-ad-gmail-com
Copy link

AndrewDemski-ad-gmail-com commented May 17, 2024

One last thing,
how was the Microsoft GitHub Policy Service / license/cla singed if WAU author was not contacted/involved n the process of importing WAU into pkgs repository?
This becomes interesting if we realize that according to CLA someone should mention the use of serviceUI.exe.

@microsoft-github-policy-service microsoft-github-policy-service bot added No-Recent-Activity No activity has occurred on this work item for seven days. and removed No-Recent-Activity No activity has occurred on this work item for seven days. labels May 17, 2024
Copy link
Contributor

Hello @G0rocks,

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any recent activity. It will be closed if no further activity occurs within 3 days of this comment.

Template: msftbot/noRecentActivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes-Requested Changes Requested Needs-Author-Feedback This needs a response from the author. No-Recent-Activity No activity has occurred on this work item for seven days. Validation-Shell-Execute
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants