Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge diverging findExecutable functions #228373

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Merge diverging findExecutable functions #228373

wants to merge 3 commits into from
+81 −123

Commits on Sep 12, 2024

  1. Merge diverging findExecutable functions 

    Patch missing from win32.findExecutable:
- microsoft@e52382a

Patch missing from findExecutable:
- microsoft@9bc292a
    @tobil4sk
    tobil4sk committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    f298c57 View commit details
    Browse the repository at this point in the history

  2. Fix path in error when executable does not exist 

    Due to the previous change, this path.join ended up joining two absolute
paths in some cases.

findExecutable now returns undefined if the path does not exist, even if
it is absolute. So it is no longer correct to assume that `command` was
relative if `foundExecutable` is undefined.
    @tobil4sk
    tobil4sk committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    acd6f2a View commit details
    Browse the repository at this point in the history

  3. Preserve previous behaviour for findExecutable use

    @tobil4sk
    tobil4sk committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    a08d991 View commit details
    Browse the repository at this point in the history