Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript-language-features] Expandable hover #228255

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gabritto
Copy link
Member

TypeScript counterpart: microsoft/TypeScript#59940

@vs-code-engineering vs-code-engineering bot added this to the September 2024 milestone Sep 13, 2024
@gabritto gabritto marked this pull request as draft September 13, 2024 17:45
@mjbvz
Copy link
Collaborator

mjbvz commented Sep 18, 2024

@gabritto Should we merge this for testing? If you prefer we can gate this behind an experimental setting too

@gabritto
Copy link
Member Author

@gabritto Should we merge this for testing? If you prefer we can gate this behind an experimental setting too

As discussed offline, I'll implement the missing part of detecting when expansion is possible or not (both in this PR and on the TSServer PR), and then we can merge this for testing.

@mjbvz can you point me to how to add a vscode setting to gate this?

@mjbvz
Copy link
Collaborator

mjbvz commented Sep 18, 2024

Thanks @gabritto. For the setting, try taking a look at typescript.autoClosingTags. If the new setting is called typescript.experimental.expandableHover, you can use something like this to check it at turn time:

vscode.workspace.getConfiguration('typescript').get('experimental.expandableHover');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants