Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jwt-cpp] Fix deps, install config #41079

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Sep 19, 2024

Resolves #41058.
Closes #35919.

CMake config was missing after the #36916 update because it didn't switch to a full installation. #35919 isn't finished, maybe because of the CMake build simply not working out of the box.

  • The lib is header-only and flexible, however the CMake config needs choices for JSON and libcrypto. No features modeled at this point.
  • picojson is the legacy choice for JSON by upstream and in the port.
  • OpenSSL is the default choice for libcrypto by upstream.

The patch is the minimal way to make the public picojson header dependency available to users, by burning the picojson location into the jwt-cpp target properties. (JWT_EXTERNAL_PICOJSON would require a CMake package or a bigger patch.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[jwt-cpp] Enforce SSL library dependency
2 participants